umputun / ralphex / 32586472500

86%

Build Type

push

github

Committed by web-flow

Commit Message

fix: surface a failed plan archive instead of reporting a clean success (#441)

* fix: surface a failed plan archive in the progress log and completion summary

When the archive commit is rejected - a commit-msg hook enforcing conventional
commits is the reported case - the plan move stays staged in the index while the
run prints "all phases completed successfully". The failure went to stderr only,
so nothing about it survived in the progress file, and a green run could hand
back a dirty tree with no recorded reason.

The failure now goes through the progress logger as a WARN, so the progress file
keeps it and a watch-mode dashboard picks it up, and the completion summary ends
with a "plan archive incomplete" line pointing at git status. The archive step
moves out of executePlan into archivePlan so the WARN itself is covered by a test
against a repo with a rejecting hook, not just the summary line.

This does not make the run non-green everywhere: the completion notification is
sent before the archive is attempted, the exit status is unchanged, and a
single-session --serve dashboard does not see the WARN. #439 stays open for the
archive commit's subject and for whether the staged rename should be rolled back.

Related to #439

* fix(test): stop the config Load tests writing to the real ~/.config/ralphex

TestLoad_SetsConfigDir and TestLoad_PopulatesAllFields call Load(""), which
resolves DefaultConfigDir() and installs the default config, prompts and agents
there. So `go test ./...` rewrote the user's own config directory on every run -
harmless while those files match the embedded defaults, and not harmless for a
config that has diverged.

Both now point HOME at a temp dir first, the same isolation
TestReset_EmptyConfigDirFallback already uses, so the default-dir path is still
exercised without touching real user state.

Coverage Stats

16 of 22 new or added lines in 1 file covered. (72.73%)

1 existing line in 1 file now uncovered.

7894 of 9355 relevant lines covered (84.38%)

225.71 hits per line