umputun / ralphex / 32404424157

86%

push

github

fix: restrict the completed-plan archive commit to the plan paths (#437)

* fix: restrict the completed-plan archive commit to the plan paths

MovePlanToCompleted ended in a bare `git commit -m`, which takes the whole
index. In worktree mode this call runs against the user's main checkout via
MainGitSvc, and that checkout stays usable for the length of the run - so
anything staged there while the run was in progress was committed under
"move completed plan: ...". The clean-tree guard in preparePlanBranch only
runs once, at worktree creation, and cannot see staging that happens later.

Switch to the pathspec-restricted commitFiles, which already exists on the
backend and lost its only production caller in #260. Unrelated staged work
now stays staged instead of being swept in.

The source path is only a valid pathspec when the move went through `git mv`;
on the os.Rename fallback the source was never tracked and naming it fails the
commit outright. The path list is therefore built from the branch actually
taken rather than by re-testing the file.

This also covers the non-worktree path, where the archive commit could
likewise absorb leftover staged work under a message that does not describe
it. Nothing documented or tested relied on that.

Related to #435

* fix: correct the fallback rationale and pin the recorded rename

Review of the previous commit found three defects in it.

The comment justifying the destination-only path list claimed the os.Rename
fallback runs only on a source git never tracked. That is not true: git mv also
refuses when the destination already exists, and resolvePlanMoveTargets returns
done=false as soon as the source exists without checking the destination, so a
tracked source reaches the fallback whenever a stale completed/ copy of the same
basename is lying around. The invariant that actually holds is narrower - the
source is a valid pathspec only when git mv staged its deletion - and both the
comment and the CLAUDE.md line ... (continued)

11 of 12 new or added lines in 3 files covered. (91.67%)

7871 of 9349 relevant lines covered (84.19%)

226.98 hits per line