decentraland / asset-bundle-registry / 32530337550

73%

push

github

feat: support a second registry instance fed by abgen (#133)

* feat: support a second registry instance fed by abgen

Adds what the asset-bundle-registry-abgen deployment needs to run the same image
against the abgen lambda's output instead of the Unity converter's.

The conversion-finished event is now configurable via
ASSET_BUNDLE_CONVERTED_EVENT_TYPE / _SUB_TYPE. The textures handler matches the
configured pair first and normalizes it before schema validation, since the
schema pins type/subType. Defaults keep today's asset-bundle/converted behaviour.

DISABLE_PROFILE_SYNC now also stops the profile ownership curation job, which
kept looping on instances that had sync off. A new DISABLE_PROFILES additionally
unregisters the /profiles endpoints — a miss there hydrates from Catalyst and
persists the result, so an instance holding no profiles must not serve them.

docker-next deploys both services to dev; manual-deploy takes a service name.

* fix: correct the documented env var defaults

The table said DISABLE_PROFILE_SYNC and DISABLE_PROFILES were unset, but
.env.default sets them to true and false and ships inside the image, so those are
what an instance runs with when its deployment sets nothing. Names the column
after the file and notes that a real environment variable always wins, since
dotenv only fills gaps.

Also returns the validator's own boolean from the textures handler's canHandle
instead of reading its mutable .errors field afterwards.

* refactor: drop the configurable conversion-finished event

The knob never varies: abgen publishes the same asset-bundle/converted pair the
Unity converter does, and which conversion events an instance sees is already
decided by the topics its queue is subscribed to. The abgen queue cannot even
receive the converter's results — its deployment subscription filters
asset-bundle events out and conversions arrive on a separate topic.

It also could not have paid off as configuration. The schema pins type/su... (continued)

670 of 957 branches covered (70.01%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 3 files covered. (100.0%)

1753 of 2351 relevant lines covered (74.56%)

40.79 hits per line