decentraland / asset-bundle-registry
73%

DEFAULT BRANCH: main
Repo Added
Token fWUYLY2oPJ2Vqa6ysDYFCXWiESarAiCav regen
Build 369 Last
Files 87
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 73.247% (+0.07%) from 73.182%
32530337550

push

github

web-flow 
feat: support a second registry instance fed by abgen (#133)

* feat: support a second registry instance fed by abgen

Adds what the asset-bundle-registry-abgen deployment needs to run the same image
against the abgen lambda's output instead of the Unity converter's.

The conversion-finished event is now configurable via
ASSET_BUNDLE_CONVERTED_EVENT_TYPE / _SUB_TYPE. The textures handler matches the
configured pair first and normalizes it before schema validation, since the
schema pins type/subType. Defaults keep today's asset-bundle/converted behaviour.

DISABLE_PROFILE_SYNC now also stops the profile ownership curation job, which
kept looping on instances that had sync off. A new DISABLE_PROFILES additionally
unregisters the /profiles endpoints — a miss there hydrates from Catalyst and
persists the result, so an instance holding no profiles must not serve them.

docker-next deploys both services to dev; manual-deploy takes a service name.

* fix: correct the documented env var defaults

The table said DISABLE_PROFILE_SYNC and DISABLE_PROFILES were unset, but
.env.default sets them to true and false and ships inside the image, so those are
what an instance runs with when its deployment sets nothing. Names the column
after the file and notes that a real environment variable always wins, since
dotenv only fills gaps.

Also returns the validator's own boolean from the textures handler's canHandle
instead of reading its mutable .errors field afterwards.

* refactor: drop the configurable conversion-finished event

The knob never varies: abgen publishes the same asset-bundle/converted pair the
Unity converter does, and which conversion events an instance sees is already
decided by the topics its queue is subscribed to. The abgen queue cannot even
receive the converter's results — its deployment subscription filters
asset-bundle events out and conversions arrive on a separate topic.

It also could not have paid off as configuration. The schema pins type/su... (continued)

670 of 957 branches covered (70.01%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 3 files covered. (100.0%)

1753 of 2351 relevant lines covered (74.56%)

40.79 hits per line

Relevant lines Covered
2351 RELEVANT LINES 1753 COVERED LINES
40.79 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32530337550 main feat: support a second registry instance fed by abgen (#133) * feat: support a second registry instance fed by abgen Adds what the asset-bundle-registry-abgen deployment needs to run the same image against the abgen lambda's output instead of th... push web-flow github
73.25
32529317338 feat/abgen-registry-instance refactor: drop the configurable conversion-finished event The knob never varies: abgen publishes the same asset-bundle/converted pair the Unity converter does, and which conversion events an instance sees is already decided by the topics its queu... Pull #133 LautaroPetaccio github
73.25
32527769410 feat/abgen-registry-instance fix: correct the documented env var defaults The table said DISABLE_PROFILE_SYNC and DISABLE_PROFILES were unset, but .env.default sets them to true and false and ships inside the image, so those are what an instance runs with when its deployment... Pull #133 LautaroPetaccio github
73.36
32523679122 feat/abgen-registry-instance feat: support a second registry instance fed by abgen Adds what the asset-bundle-registry-abgen deployment needs to run the same image against the abgen lambda's output instead of the Unity converter's. The conversion-finished event is now confi... Pull #133 LautaroPetaccio github
73.37
32250039004 fix/crypto-middleware-6 refactor(auth): use rejectIfSigner from crypto-middleware 6.1 Replaces the hand-rolled scene gate. The exact comparison let a signer that was not already canonical through: a padded or re-cased value failed `!== 'decentraland-kernel-scene'` and t... push LautaroPetaccio github
73.18
32250059223 main fix(auth): upgrade @dcl/crypto-middleware to 6 (#132) * fix(auth): upgrade @dcl/crypto-middleware to 6 6.0.0 changes the signed-fetch wire format: the payload is now `[method.toLowerCase(), path.toLowerCase(), timestamp, metadata].join(':')` ins... push web-flow github
73.18
32186709651 fix/crypto-middleware-6 refactor(auth): use rejectIfSigner from crypto-middleware 6.1 Replaces the hand-rolled scene gate. The exact comparison let a signer that was not already canonical through: a padded or re-cased value failed `!== 'decentraland-kernel-scene'` and t... Pull #132 LautaroPetaccio github
73.18
32176287535 fix/crypto-middleware-6 fix(auth): upgrade @dcl/crypto-middleware to 6 6.0.0 changes the signed-fetch wire format: the payload is now `[method.toLowerCase(), path.toLowerCase(), timestamp, metadata].join(':')` instead of lowercasing the whole joined string, so the metad... Pull #132 LautaroPetaccio github
73.19
32033038359 feat/serve-default-profiles-from-catalyst test: pin default profile parity with what lambdas serves A default profile has to come back from here exactly as lambdas serves it. Both return it today with the deployer address it was deployed with, checksummed, and no `userId` at all, since t... Pull #131 LautaroPetaccio github
73.5
31841065984 feat/serve-default-profiles-from-catalyst feat: serve default profiles from the catalyst fallback A default profile pointer that missed the cache and the database resolved to nothing, so `/profiles` answered for an address but not for a name it accepts. Lambdas reports every default pro... Pull #131 LautaroPetaccio github
73.5
See All Builds (369)

Badge your Repo: asset-bundle-registry

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh