supabase / supabase-swift / 32518023541

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest)!: reject nil filter operands at compile time (#1238)

`Optional` conformed to `PostgrestFilterValue` and rendered `nil` as the
literal text `NULL`, so `eq("email", value: nilString)` compiled and sent
`email=eq.NULL`. Verified against PostgREST 14.15, that is not a no-op: on
an `integer` column it is an HTTP 400, but on a `text` column it returns
HTTP 200 with the row whose value is the string `'null'` — a silently wrong
row rather than an empty result.

`column = NULL` is never true in SQL, so there is no correct query to send.
Rather than translate `nil` into `is.null` behind the caller's back, make it
impossible to express: split out `PostgrestArrayElement` as the weaker
protocol, have `PostgrestFilterValue` refine it, and conform `Optional` to
the base only. Passing an optional to a comparison filter is now a compile
error, while real array columns keep their `NULL` members.

`PostgrestFilterValue` refines the new protocol and supplies a default
implementation, so existing custom conformances keep compiling untouched.

BREAKING CHANGE: `Optional` no longer conforms to `PostgrestFilterValue`.
Use `is(_:value:)` to test for NULL. See V3_MIGRATION.md.

Coverage Stats

14 of 14 new or added lines in 2 files covered. (100.0%)

19 existing lines in 2 files now uncovered.

9134 of 10487 relevant lines covered (87.1%)

45.23 hits per line