coreui / coreui-pro / 32517018383

93%

main: 94%

push

github

refactor(Root): build the root tokens as a map, and turn on order/order (#833)

`:root` was 200 lines of declarations with six `@each` loops threaded through
them. Upstream's is four lines — they assemble `$root-tokens` in Sass and emit
it with one `tokens()` call, which is why `order/order` passes on their tree
and produced two violations on ours: the rule was not objecting to sloppy
ordering, it was pointing at the difference in how the block is built.

So build the map instead. `color-tokens()` and `theme-color-tokens()` become
functions returning maps, with the mixins kept as thin wrappers; the loops
write into the map; and `:root` is left with `@include tokens($root-tokens)`
and the `color-scheme` declaration that has to be a declaration. The set gets
one override point, `$root-tokens`, the same shape every component already has.

Two knock-on effects worth naming:

`--cui-btn-input-font-family` stops being emitted. `$input-btn-font-family` is
null, and the old code interpolated it into `--cui-btn-input-font-family: ;` —
an empty custom property, which makes every `var()` reading it invalid at
computed-value time. Four rules read it with no fallback, so they resolved to
the inherited family before and still do; the token is now honestly absent
rather than present and broken. One of the nine empty tokens gone.

Two values print as `0.15s` and `cubic-bezier(0.34, …)` rather than `.15s` and
`.34`, because they now pass through Sass as numbers instead of being
interpolated as text. Same values, and the leading-zero form already appears
28 times elsewhere in the compiled output.

With `_root.scss` no longer interleaving, `order/order` costs nothing: the two
remaining violations were a `$` variable sitting below a rule in
`_input-group.scss` and `_containers.scss`, both moved to the top of the block
that uses them.

4537 of 5095 branches covered (89.05%)

Branch coverage included in aggregate %.

8661 of 9055 relevant lines covered (95.65%)

399.93 hits per line