source-academy / py-slang / 32512435957

86%

push

github

Fix evaluator builds on Windows (#444)

build.ts spawns "rollup" and pynter-parity-report.ts spawns "npx". Neither
resolves on Windows: the only thing on PATH is the .CMD binstub, and spawn()
doesn't do PATHEXT lookup, so both come back ENOENT. Naming the .cmd directly
doesn't work either, since Node stopped allowing batch files to be spawned
without a shell after CVE-2024-27980.

So yarn build --evaluator, yarn build --all and yarn dev all fail. build:repl
is the exception, because yarn runs that through a shell that does find the
binstub.

Using createRequire to find rollup's and jest's own entry points, then running
those under process.execPath, avoids the whole problem. I went this way rather
than passing shell: true because that triggers the DEP0190 warning about
arguments being concatenated instead of escaped.

yarn build --all works on Windows now. PyCseEvaluator4.js comes out at the same
492,144 bytes as before, so nothing about the output has changed.

4826 of 6064 branches covered (79.58%)

Branch coverage included in aggregate %.

10804 of 12197 relevant lines covered (88.58%)

161944.14 hits per line