source-academy / py-slang / 31726053645

86%

Build Type

push

github

Committed by web-flow

Commit Message

Py2JS/Stepper: unify the predicate-type-error message for if/elif and ternary (#440)

Martin flagged that the two messages introduced in #439 ("if condition must
be bool, not 'int'" and "conditional expression condition must be bool, not
'int'") read like two different checks instead of one shared rule, and don't
match the style of an ordinary operand-type error (e.g. "unsupported operand
type(s) for -: 'int' and 'str'").

Both constructs now share one message: "predicate type must be 'bool', not
'<type>'" - "predicate" being SICP's term for the condition in both an if
statement and a conditional expression.

- py2js: condBool no longer takes a `where` parameter (the message no longer
  varies by construct), so its two Ternary call sites and its If call site in
  compiler.ts are simplified accordingly.
- stepper: contractConditional and the IfStatement case in reduce.ts now
  throw the same unified message.


Claude-Session: https://claude.ai/code/session_01CbR13vUwRM71FdD4zoiDuY

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

Coverage Stats

4826 of 6064 branches covered (79.58%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

38 existing lines in 5 files now uncovered.

10804 of 12197 relevant lines covered (88.58%)

161944.14 hits per line