nbari / mariadb_exporter / 32462534094

88%

main: 89%

Build Type

push

github

Committed by nbari

Commit Message

Pin the metric name/type/help wire contract with a golden fixture

The 0.8.0 settlement refactor makes an unreadable source absent rather than a
fabricated zero, so the set of exported families now varies legitimately with
server version, plugins and privileges. What must never vary is a family's name,
Prometheus type or HELP string, since dashboards, recording rules and alerts are
written against those.

An old-vs-new scrape diff caught three HELP strings that drifted when the
replica summary moved out of default/status.rs into its own default/replication.rs
leaf. Restore them to the exact 0.7.0 wording.

Add tests/metric_metadata.rs and tests/fixtures/metric_metadata.tsv to stop that
class of drift recurring. The check is asymmetric on purpose: every family
observed in a live scrape must appear in the fixture with an identical type and
help string, while fixture rows with no matching family are tolerated because the
source may simply be unavailable on the server under test. Mutation-checked by
reverting the HELP fix, which fails with an expected/observed diff.

Also fix a doc_markdown clippy error in the new test module.

Fix clippy on Rust 1.98 and stop the devcontainer drifting behind CI

CI lints with dtolnay/rust-toolchain@stable (1.98.0), which extended
clippy::manual_is_variant_and to cover `.ok().is_some_and(..)` on a Result. The
repo denies clippy::pedantic, so four call sites that a 1.97 clippy accepted broke
the build. Replace them with `is_ok_and`.

CI only reported the two in settlement_transitions.rs because compilation stopped
there; testcontainers.rs had two more that would have failed on the next run.

The underlying problem is that local and CI toolchains drift. In the devcontainer
Rust comes from the base image rather than mise, and ~/.rustup is a named volume
that survives rebuilds, so pulling a newer image does not update Rust and the
container lints against a smaller set of pedantic lints than CI does. Every Rust
release that ad... (continued)

Coverage Stats

2919 of 3344 new or added lines in 48 files covered. (87.29%)

82 existing lines in 9 files now uncovered.

8342 of 9427 relevant lines covered (88.49%)

247.48 hits per line