umputun / tg-spam / 32407754546

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: make dynamic lua reload reach the running checks (#445)

createMetaChecker captured the *lua.LFunction and the detector keeps those closures for the
life of the process, so a reload swapped a registry entry nothing ever read again and an
edited rule kept its old verdict until restart while the log said it reloaded. The closure
now resolves the function on every call, inside the write lock it already holds.

ReloadScript deleted the map entry before validating, so a syntax error left nothing
registered while the detector still held and ran the old closure: the plugin vanished from
GetLuaPluginNames and the admin UI while it went on classifying. LoadScript already validates
in a throwaway state and writes the map only on success, so ReloadScript just calls it. Its
godoc states the limit of that guarantee, since a candidate that reassigns a global before
failing has already changed what the previous version does.

The watcher's deleted-file branch skipped its own delete of the pending event, so one removed
script was re-logged every debounce tick for the life of the process. Its message now asks the
registry before claiming anything, and claims only that the entry survives.

Not covered: newly created files still do not reach the detector, there is no runtime unload,
and fsnotify.Rename is untracked.

Related to #444

Coverage Stats

19 of 24 new or added lines in 2 files covered. (79.17%)

2 existing lines in 1 file now uncovered.

9012 of 10743 relevant lines covered (83.89%)

241.05 hits per line