pantsbuild / pants / 32350408746

93%

push

github

fix(golang): record a build ID when linking Go binaries (#23632)

## Problem

The Go backend doesn't pass a -buildid to `go tool link`. It does for
`go tool compile`. Also go build effectively always provides one, it's
conditional only on having the build cache enabled which is mandatory
since 1.12.

This is causing some problems on macOS, as when go internally links, it
only emits LC_UUID if there is a buildid (on 1.24+). The dyld loader on
macOS started enforcing executables to have a LC_UUID for binaries built
for SDK/OS 26. Without one on a binary built for that SDK version it
cannot be executed on macOS 26.

This is somewhat narrow, as a pure go binary emits a hard coded SDK
version 12, which is exempt from the enforcement. And when building with
CGO the SDK version is the hosts (so can be in play), but if it's
externally linked it gets an LC_UUID from that linker instead. When it
does happen is when building a binary where the closure includes only
internal CGO dependencies that are allowlisted by Go to be linked
internally. This includes `runtime/cgo` and when using `race=True`. A
binary built by pants in that case is not runnable on macOS 26.

An example case that this hits is depending on `testcontainers-go`,
which depends on `ebitengine/purego`, which pulls in only `runtime/cgo`.
This ends up on the path with an internal linker not emitting LC_UUID
but emitting an SDK stamp of the host system that is affected by the
enforcement. Running that binary fails with `dyld[317]: missing LC_UUID
load command`.

Also more cosmetically it is a divergence from `go build` to omit a
buildid, which some go tooling otherwise can use.

Worth noting is that Go does [fix the missing LC_UUID in some unreleased
version](https://go-review.googlesource.com/c/go/+/751260/4/src/cmd/link/internal/ld/macho.go#854-860).
But I think this fix is still valid since `go build` does provide a
buildid to link still, and it also fixes the unpatched versions of Go.

## Fix

Pro... (continued)

66 of 67 new or added lines in 2 files covered. (98.51%)

95481 of 102785 relevant lines covered (92.89%)

3.66 hits per line