ruby-grape / grape / 32340656610

97%

master: 97%

Pull #2846

github

Keep a :version path capture when the API declares no version

Grape::Request#make_params dropped :version from the routing args
unconditionally, alongside :route_info. That is right when Grape put it
there -- a path-versioned API captures the version as a segment and exposes
it through env['api.version'] rather than params -- but it is not always
Grape's.

An API that declares no version can name a param :version:

    route_param :version do
      get { params[:version] }    # => nil
    end

The route matched and Mustermann captured the segment, but the value was
filtered out before the endpoint saw it, so params[:version] came back nil
and the key was absent from params entirely. Same for a bare
get '/:version'. Silent loss of a segment on a route that had matched.

A route reports a #version only when the API declared one, so use that to
tell the two apart: drop the capture when the route carries a version,
keep it otherwise. Path, header and param versioning are unaffected --
their routes all report a version, so :version stays out of params and
env['api.version'] remains the way to read it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

1218 of 1307 branches covered (93.19%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

3836 of 3903 relevant lines covered (98.28%)

27083.43 hits per line