decentraland / comms-gatekeeper / 32314105557

86%

main: 86%

Pull #289

github

feat(auth): accept the legacy payload on explorer-facing routes

Upgrading to crypto-middleware 6 breaks every explorer client: unity,
godot and bevy all still sign the pre-6.0.0 payload, and the metadata they
send is camelCase throughout, so folding it is never a no-op. Those are
three separate client releases and none can be deployed atomically with
this service, so no deploy order avoids breaking scene comms.

6.2.0's canonicalMetadataKeys accepts those requests for the rollout
window. The current format is still tried first; only a signature mismatch
falls back. Before accepting a legacy request every declared key must
arrive in exactly that spelling, so a re-spelled key cannot read as absent
the way the folded payload would otherwise allow.

The list is derived from what this service actually reads — the validators
in routes.ts plus the destructures in logic/utils.ts and the cast and
private-message handlers — not from the fields explorers happen to send.
It is exported so the two places that verify stay in step.

Scoped to the routes explorers sign: the scene-adapter path through
validate()/oldValidate(), and the auth, authSceneOrServer and authExplorer
middlewares. Watcher tokens and the user-moderation routes stay strict and
say why: the cast web app and internal tooling sign empty or all-lowercase
metadata, which is byte-identical under both formats.

Remove this, and the legacy test helper with it, once the explorer
releases have rolled out.

1145 of 1456 branches covered (78.64%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

3137 of 3525 relevant lines covered (88.99%)

78.42 hits per line