umputun / tg-spam / 32313463989

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: lua state race, logged database credentials, cross-group dictionary delete (#439)

* fix(plugin): serialize lua checks on the shared state with the write lock

createMetaChecker took a read lock while the closure body allocates tables on
the shared *lua.LState and pushes and pops its stack. gopher-lua states are not
goroutine-safe, and Detector.Check holds only a read lock of its own, so
concurrent checks (parallel /check requests, or a busy update loop) ran the same
VM in parallel and could corrupt results or panic inside gopher-lua.

The existing concurrency test only ever had one checking goroutine, so it never
exercised this; the new test drives the same check from several goroutines and
reproduces the race without the fix.

* fix(storage): scope dictionary delete by gid

Every read on the dictionary table filters by gid, but Delete matched on id
alone while the id comes straight from the web API request body. Instances of
different groups sharing one database could therefore delete each other's stop
phrases and ignored words by passing an id from the neighbouring group.

* fix(storage): redact database credentials in logs and errors

engine.New logged the full connection URL at INFO on every connection, so any
postgres deployment printed its password on startup; makeDB repeated it at DEBUG
and in the wrapping error, and with --dbg the settings dump printed
Transient.DataBaseURL verbatim.

RedactConnURL masks userinfo passwords and sensitive query parameters for
display, and the settings dump now prints a copy carrying the masked URL. The
secret masker would not have covered that dump: it matches literal substrings,
so a percent-encoded password in the URL would have slipped through, and in
--confdb mode makeDB runs before setupLog anyway. The url.Parse failure path is
unwrapped so *url.Error does not carry the original URL back into the message.
The value handed to sqlx is unchanged.

* docs(webapi): correct the settings warning about creden... (continued)

Coverage Stats

63 of 68 new or added lines in 5 files covered. (92.65%)

2 existing lines in 1 file now uncovered.

9007 of 10742 relevant lines covered (83.85%)

234.68 hits per line