ThePalaceProject / web-patron / 32297395938

30%

push

github

Move English strings into translation files (PP-4709) (#184)

# Description
The next step in internationalizing `web-patron` involves moving all
hard-coded English strings into translation files. Translation keys have
been created that map to English strings:
```json
"accountMenu.account": "Account",
"accountMenu.closeMenu": "Close account menu",
"libraryFilterList.librariesMatched_one": "{{count}} library shown, best matches first",
"libraryFilterList.librariesMatched_other": "{{count}} libraries shown, best matches first",
```

<!--- Describe your changes -->
### Features & Notable Changes
- All hard-coded strings have been replaced with `t(...)` functions and
`<Trans />` components provided by `next-i18next/pages`.
- `t(...)` functions accept a translation key as their first argument. A
default value can be provided as a fallback when that function's
translation key doesn't exist in the current locale; otherwise the
translation key itself would be rendered on the screen. This default
value can be provided as standalone string or as a property of the
options object, which can take the form `defaultValue` or as a variation
of one of the several plural form options that exist, e.g.
`defaultValue_one`, `defaultValue_two`, `defaultValue_many`. The second
argument can either be the default value or the options object. If
default value string is provided in the second argument, the options
object can be provided as a third argument.
- The `<Trans />` component can accept JSX elements or native HTML
elements as children, which can be useful when interpolating link
elements or certain semantic elements like `<b />` or `<em />`.
- OPDS parsers now collect raw values for `published` and `duration`
from entries and move formatting to the components in which these values
are rendered to the UI.
- A new date utility leverages the browser-native `Intl.DateTimeFormat`
API to format `published` values based on locale. A new duration utility
uses a polyfill from `@f... (continued)

326 of 1467 branches covered (22.22%)

Branch coverage included in aggregate %.

15 of 94 new or added lines in 26 files covered. (15.96%)

705 of 2049 relevant lines covered (34.41%)

9.24 hits per line