ThePalaceProject / web-patron / 31813085213

30%

push

github

Feature flag gates language selection support (PP-4937) (#183)

Adds a PALACE_CPW_FEATURE_LANGUAGE_SELECTOR environment variable feature
flag (default off) that gates all patron-facing language support,
following the existing PALACE_CPW_FEATURE_OPDS2 pattern:

- Language selector: with the flag off, the selector in the catalog
header is not rendered at all, so it is absent from the accessibility
tree.
- Automatic locale detection: with the flag off, the NEXT_LOCALE cookie
and Accept-Language header are stripped from inbound requests before
Next.js sees them, so every patron is served the default (English)
locale. This is done dynamically at the HTTP layer in instrumentation.ts
because the standalone build bakes next.config.js values in at build
time, so i18n.localeDetection cannot follow a runtime environment
variable. A patron's saved locale cookie is ignored, not cleared, so
their choice resumes working when the flag is enabled.
- Locale-prefixed URLs: a new request proxy (src/proxy.ts, Next 16's
successor to the middleware convention) 307-redirects bookmarked /
hand-typed / etc. locale URLs (e.g. /es/...) to the same path in the
default locale.

With the flag on, behavior is exactly as delivered in PP-4708. The i18n
runtime, message catalogs, and tooling remain active in both flag
states. The flag is documented in the README and .env, its state is
logged at server startup, and the flag env var names moved to
src/constants/env.ts so the proxy can import them without pulling in the
Node-only config loader.

Motivation and Context

PP-4708 shipped the i18n framework, including a patron-facing language
switcher, but other elements of the localization epic is still in
progress, so the non-English catalogs are stubs that fall back to
English. A patron who selects one of those languages might be confused
by the lack of translation. This flag can hide the switcher and prevents
any locale other than English from activating, so the framework can keep
shippin... (continued)

313 of 410 branches covered (76.34%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 3 files covered. (100.0%)

526 of 607 relevant lines covered (86.66%)

30.57 hits per line