thoughtspot / mcp-server / 32284020175

90%

Build Type

push

github

Committed by web-flow

Commit Message

[SCAL-327336] Fix org tools disappearing after token expiry: reconcile token before getSessionInfo (#199)

* [SCAL-327336] Fix org tools disappearing after token expiry: reconcile token before getSessionInfo

sessionInfo is fetched once at init via getSessionInfo(). Previously that ran
before the keep-warm global token was reconciled from the token-store DO, so on
a cold-start reconnect after the frozen props access token expired (~24h),
getSessionInfo authenticated with the dead token, failed, and left sessionInfo
null for the DO's lifetime — silently hiding list_orgs/switch_org and mis-gating
feature flags, even though the DO still held a valid kept-warm token.

- Reorder: a preInit() hook reconciles the global token from the token-store DO
  before initializeService()/getSessionInfo, so the init fetch authenticates with
  the kept-warm token and sessionInfo is populated correctly at connect.
- ensureSessionInfo(): fallback in listTools that refetches session info if it's
  still null (e.g. a transient init failure), guarded by an in-flight promise so
  concurrent list calls share one fetch (no duplicate getSessionInfo / tracker).
- isOrgsEnabled() defaults to true when sessionInfo is absent so org tools stay
  visible in the brief window before the refetch completes.
- callTool reconciles the global token per call keyed on the absence of an active
  org token, so a data call always gets a fresh global token when no org token
  drives it.
- Extract postInit's active-org bootstrap into ensureActiveOrg().

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address review: clarify session-info/token-expiry logs+comments, drop dead param, harden test

Review follow-ups on the session-info repair PR:

- Logs/comments: make the session-info-failure and token-expiry paths
  self-explaining. initializeService, preInit keep-warm load, and the active-org
  bootstrap failures now log WHY they're non-fatal and WHAT the fallback is
  (org to... (continued)

Coverage Stats

1047 of 1216 branches covered (86.1%)

Branch coverage included in aggregate %.

42 of 45 new or added lines in 3 files covered. (93.33%)

1 existing line in 1 file now uncovered.

1834 of 2015 relevant lines covered (91.02%)

1135.17 hits per line