supabase / supabase-flutter / 32267202794
89%

DEFAULT BRANCH: main
Ran
Jobs 10
Files 108
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.752% (+0.03%) from 88.72%
32267202794

push

github

web-flow 
refactor!: remove the dead setAccessToken mutators (#1739)

## Summary

Removes `PostgrestClient.setAccessToken()`,
`SupabaseStorageClient.setAccessToken()` and
`FunctionsClient.setAccessToken()`. `RealtimeClient.setAccessToken()`
stays.

Nothing in the repository called the three that are gone, but they were
not inert either. Despite the name they pinned a token rather than kept
one in sync: `AuthHttpClient` applies the current session token with
`putIfAbsent`, so an `Authorization` header set through one of these
setters took precedence over it, and nothing ever cleared it. The pinned
token kept shadowing the session across refreshes and sign-outs for the
rest of the client's life. A method named `setAccessToken` on a client
that is otherwise authenticated per request is a poor way to spell that.

The capability survives without them. The header maps are still mutable,
so a token can be pinned with `supabase.rest.headers['Authorization'] =
...` or `storage.setHeader(...)`, passed to a constructor, or scoped to
a single call with `invoke(headers: ...)` / `.setHeader(...)`. What goes
away is four inconsistent signatures for the same idea, one of which
reads like auth synchronization.

Realtime is the real case for a setter: it holds a live socket and has
to push a new token over it rather than attach one per request, so
`SupabaseClient` genuinely calls its setter on auth state changes.

## Why

Mirrors https://github.com/supabase/supabase-swift/pull/1233, which
removed the equivalent `FunctionsClient.setAuth(token:)` from
supabase-swift in favour of a per-request access token closure. Flutter
already resolves the token per request through `AuthHttpClient`, so only
the cleanup half applies here.

The header-clobbering bug that PR also fixed does not exist in this SDK:
`putIfAbsent` means an `Authorization` passed to a single `invoke` or
query survives the live token. `client_test.dart` now covers that end to
end, since it is the replacement this migrat... (continued)

5894 of 6641 relevant lines covered (88.75%)

4.3 hits per line

Jobs
ID Job ID Ran Files Coverage
6 supabase_functions - 32267202794.6 3
97.7
 GitHub Action Run
7 supabase_flutter - 32267202794.7 10
81.92
 GitHub Action Run
8 supabase_storage - 32267202794.8 8
97.39
 GitHub Action Run
9 supabase - 32267202794.9 13
91.28
 GitHub Action Run
10 postgrest - 32267202794.10 10
85.06
 GitHub Action Run
7 supabase_realtime - 32259216865.7 12
90.19
 GitHub Action Run
9 iceberg - 32259216865.9 5
68.62
 GitHub Action Run
4 supabase_common - 32259216865.4 17
97.22
 GitHub Action Run
2 supabase_auth - 32259216865.2 29
90.72
 GitHub Action Run
2 yet_another_json_isolate - 32034091672.2 1
94.44
 GitHub Action Run
Source Files on build 32267202794