supabase / supabase-flutter / 32259216865

89%

Build Type

push

github

Committed by web-flow

Commit Message

refactor!: share one retry configuration across the clients (#1738)

Stacked on #1737, so review that one first. This diff is against that
branch.

## What

Retry was configured differently in every client: `postgrest` took a
`PostgrestRetryOptions`, `supabase_storage` took an `int`, and the auth
token refresh hardcoded its own numbers with no way to change them. All
three take one `SupabaseRetryOptions` now.

```dart
final supabase = SupabaseClient(
  supabaseUrl,
  supabaseKey,
  postgrestOptions: const PostgrestClientOptions(
    retryOptions: SupabaseRetryOptions(count: 5),
  ),
  storageOptions: const StorageClientOptions(
    retryOptions: SupabaseRetryOptions(count: 5),
  ),
  authOptions: const AuthClientOptions(
    retryOptions: SupabaseRetryOptions(count: 5),
  ),
);
```

The type carries `enabled`, `count`, `initialDelay`, `maxDelay` and
`randomizationFactor`, plus `delay(attempt)`, `copyWith` and value
equality. What counts as a retryable failure stays with each client,
since those are not interchangeable: PostgREST repeats a read that
answered with `503` or `520`, storage repeats an upload that hit a
network error, and auth repeats a token refresh that never reached the
service. The loops stay separate too, because the PostgREST one retries
on a response status while the other two retry on a thrown exception.

### Where the type lives

`supabase_common` is the only package all three clients depend on, so
declaring the shared type in a client package would mean making storage
depend on postgrest. It is declared there and re-exported from
`postgrest`, `supabase_storage`, `supabase_auth`, `supabase` and
`supabase_flutter`.

`supabase_common` is excluded from the capability-matrix scan as a
whole, which would have made the knobs unregistrable.
`.sdk-parse-ignore` now excludes the package's sources with a negation
for `retry_options.dart` alone, so the one genuinely user facing file of
that package is scanned and the rest stays internal.

###... (continued)

Coverage Stats

54 of 59 new or added lines in 8 files covered. (91.53%)

1 existing line in 1 file now uncovered.

5899 of 6649 relevant lines covered (88.72%)

4.3 hits per line