nats-io / nats-server / 32217291950
74%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 67
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 75.988% (+0.4%) from 75.636%
32217291950

push

github

web-flow 
[FIXED] Missing stream snapshot on shutdown, plus test de-flakes (#8465)

Two problems prevented a stream from snapshotting on shutdown:

- `doSnapshot` suppressed the snapshot when an async checkpoint was
still in progress (`errSnapInProgress`) or when `failedSnapshots > 0`.
On shutdown we now bypass both and force-install directly, which aborts
any in-flight checkpoint.
`TestNRGForcedInstallSnapshotAbortsInProgressCheckpoint` covers that the
aborted checkpoint can no longer load or install, and that its late
`Abort()` doesn't cancel the freshly installed snapshot. (This was
already the case before this PR, but now has test coverage)
- `monitorQuitC` recreated `mset.mqch` when it was nil, so a monitor
goroutine starting after `stopMonitoring` had already signaled would
wait on a channel that would never close, and `stopMonitoring` would
block on `monitorWg` forever. It now returns a pre-closed channel
instead; `startMonitorWg` creates the quit channel and skips it when the
stream is closed or closing.

`stream.stop` now waits for the monitor routine when shutting down (and
not deleting), so the shutdown snapshot actually completes before
teardown continues.

Also de-flakes `TestJetStreamClusterAsyncFlushBasics` and
`TestJetStreamClusterCreateR3StreamWithOfflineNodes`, and fixes a data
race on `Group.node` in the health check test helpers.

Various tests also started flaking with `JetStream system temporarily
unavailable` due to consistently changing to `lostQuorumInterval` in
https://github.com/nats-io/nats-server/pull/8452, the test-only 2s is
bumped to 5s.

73214 of 96350 relevant lines covered (75.99%)

544338.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
69
78.75
 -0.58% src/github.com/nats-io/nats-server/server/filestore.go
34
83.63
 -0.09% src/github.com/nats-io/nats-server/server/jetstream_cluster.go
29
87.82
 -0.27% src/github.com/nats-io/nats-server/server/consumer.go
18
80.92
 0.88% src/github.com/nats-io/nats-server/server/raft.go
17
62.3
 0.08% src/github.com/nats-io/nats-server/server/opts.go
7
58.12
 3.33% src/github.com/nats-io/nats-server/server/jetstream_errors_generated.go
6
93.51
 -0.24% src/github.com/nats-io/nats-server/server/gateway.go
5
72.13
 0.71% src/github.com/nats-io/nats-server/server/jetstream_api.go
5
85.3
 -0.15% src/github.com/nats-io/nats-server/server/server.go
4
85.07
 -0.05% src/github.com/nats-io/nats-server/server/events.go
4
81.38
 -0.37% src/github.com/nats-io/nats-server/server/parser.go
4
86.42
 2.04% src/github.com/nats-io/nats-server/server/stream.go
3
87.7
 -0.06% src/github.com/nats-io/nats-server/server/client.go
3
90.9
 -0.38% src/github.com/nats-io/nats-server/server/jetstream_batching.go
3
82.15
 0.0% src/github.com/nats-io/nats-server/server/route.go
Jobs
ID Job ID Ran Files Coverage
1 32217291950.1 67
75.99
 GitHub Action Run
Source Files on build 32217291950