go-pkgz / fileutils / 32220826345

72%

master: 72%

Pull #11

github

fix IsFile and IsDir panicking on a stat error other than not-exist

exists guarded only os.IsNotExist, so any other stat failure fell through to
info.IsDir() with info nil. A path under a directory the process cannot read,
or a path the OS rejects outright, panicked with a nil pointer dereference
instead of reporting that the file is not there.

Every stat failure now reports false. Nothing that previously returned a value
changes, only the cases that panicked.

MoveFile gains an unexported moveFile taking the rename call as an argument.
The existing fallback test never reached the copy+delete branch: its first
rename failed only because the destination directory was missing, and the retry
after MkdirAll succeeded. It is renamed to say what it actually covers, and a
new case forces rename to fail so the fallback carries the move, asserting the
two rename attempts and the moved content.

TouchFile tests no longer depend on wall clock. The 100ms sleep is replaced by
backdating the file with os.Chtimes, which also makes the assertion independent
of filesystem timestamp resolution, and the creation case bounds the
modification time from below rather than measuring how fast the runner is.

6 of 6 new or added lines in 1 file covered. (100.0%)

246 of 340 relevant lines covered (72.35%)

4.44 hits per line