go-pkgz / lcw / 32208387310

94%

master: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix size limits, key limits, load stampede, redis namespacing and scoped flush (#51)

* apply go fix: interface{} to any, sort.Slice to slices.Sort

mechanical rewrite produced by go fix, no behaviour changes

* update dependencies, replace go-multierror with errors.Join

go-redis to v9.18.0, miniredis to v2.38.0, testify to v1.12.0, uuid to v1.6.0,
all the latest versions still compatible with the go 1.21 directive.

hashicorp/go-multierror dropped in favour of the standard errors.Join,
which changes the combined error text in url parsing.

* fix CI: test and build all packages, pin goveralls, explicit push refs

go test and go build ran without ./... so eventbus and internal/cache were never
tested in CI. go get -v dropped, it modified the dependency graph instead of
validating the committed one. goveralls pinned to a release instead of @latest.
push trigger got explicit branches and tags, the empty form is flagged by actionlint.

* fix size accounting, key limits, load stampede and redis namespacing

size limits: MaxCacheSize and MaxValSize only applied to values implementing
Sizer, so []byte and string values were never limited at all. Both are now sized
by length, which makes the limits effective for Scache and any []byte cache.

MaxKeys(0): documented as unlimited, but the expirable cache rejected every
insert and the lru constructor returned an error. Zero now means unlimited
everywhere, matching the docs.

concurrent loads: overlapping Get calls for the same missing key each ran the
loader, added the value and counted its size again. With sized values this drove
currentSize above maxCacheSize and left the lru eviction loop spinning over an
empty cache. Loads are coordinated per key now, so the loader runs once and the
rest wait for its result. The lru eviction loop also stops when the backend is
empty instead of looping forever.

redis namespacing: the cache treated the whole selected database as its own, so
keys could collide with unrelated d... (continued)

Coverage Stats

417 of 463 new or added lines in 20 files covered. (90.06%)

1 existing line in 1 file now uncovered.

1530 of 1622 relevant lines covered (94.33%)

17848.11 hits per line