go-pkgz / lcw
94%
master: 94%

LAST BUILD BRANCH: refs/tags/v2.1.0
DEFAULT BRANCH: master
Repo Added
Files 22
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH refs/tags/v2.1.0
branch: SELECT
CHANGE BRANCH
x

coverage: 94.328% (-1.1%) from 95.419%
32208387310

push

github

web-flow 
fix size limits, key limits, load stampede, redis namespacing and scoped flush (#51)

* apply go fix: interface{} to any, sort.Slice to slices.Sort

mechanical rewrite produced by go fix, no behaviour changes

* update dependencies, replace go-multierror with errors.Join

go-redis to v9.18.0, miniredis to v2.38.0, testify to v1.12.0, uuid to v1.6.0,
all the latest versions still compatible with the go 1.21 directive.

hashicorp/go-multierror dropped in favour of the standard errors.Join,
which changes the combined error text in url parsing.

* fix CI: test and build all packages, pin goveralls, explicit push refs

go test and go build ran without ./... so eventbus and internal/cache were never
tested in CI. go get -v dropped, it modified the dependency graph instead of
validating the committed one. goveralls pinned to a release instead of @latest.
push trigger got explicit branches and tags, the empty form is flagged by actionlint.

* fix size accounting, key limits, load stampede and redis namespacing

size limits: MaxCacheSize and MaxValSize only applied to values implementing
Sizer, so []byte and string values were never limited at all. Both are now sized
by length, which makes the limits effective for Scache and any []byte cache.

MaxKeys(0): documented as unlimited, but the expirable cache rejected every
insert and the lru constructor returned an error. Zero now means unlimited
everywhere, matching the docs.

concurrent loads: overlapping Get calls for the same missing key each ran the
loader, added the value and counted its size again. With sized values this drove
currentSize above maxCacheSize and left the lru eviction loop spinning over an
empty cache. Loads are coordinated per key now, so the loader runs once and the
rest wait for its result. The lru eviction loop also stops when the backend is
empty instead of looping forever.

redis namespacing: the cache treated the whole selected database as its own, so
keys could collide with unrelated d... (continued)

417 of 463 new or added lines in 20 files covered. (90.06%)

1 existing line in 1 file now uncovered.

1530 of 1622 relevant lines covered (94.33%)

17848.11 hits per line

Relevant lines Covered
1622 RELEVANT LINES 1530 COVERED LINES
17848.11 HITS PER LINE
Source Files on master

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
32208387310 refs/tags/v2.1.0 fix size limits, key limits, load stampede, redis namespacing and scoped flush (#51) * apply go fix: interface{} to any, sort.Slice to slices.Sort mechanical rewrite produced by go fix, no behaviour changes * update dependencies, replace go-mul... push web-flow github
94.33
32208386496 refs/tags/v1.2.0 fix size limits, key limits, load stampede, redis namespacing and scoped flush (#51) * apply go fix: interface{} to any, sort.Slice to slices.Sort mechanical rewrite produced by go fix, no behaviour changes * update dependencies, replace go-mul... push web-flow github
94.27
32196080946 master fix size limits, key limits, load stampede, redis namespacing and scoped flush (#51) * apply go fix: interface{} to any, sort.Slice to slices.Sort mechanical rewrite produced by go fix, no behaviour changes * update dependencies, replace go-mul... push web-flow github
94.14
32195463077 fix-cache-semantics harden loader panic release, redis error path and expiry tests waiters are released with a fixed sentinel error instead of one formatted from the panic value, so no method of that value runs before they are freed. the v2 redis recheck error path... Pull #51 paskal github
94.27
32189879879 fix-cache-semantics reference upstream issue for the v2 expirable callback caveat Pull #51 paskal github
94.6
19903546292 master Fix CI workflow: checkout before setup-go for proper caching (#50) - Move checkout step before setup-go to enable Go module caching - setup-go needs go.mod/go.sum files to generate cache keys - Update golangci-lint action to v7 and version to v2.... push web-flow github
95.42
19900758529 fix-ci-caching Fix CI workflow: checkout before setup-go for proper caching - Move checkout step before setup-go to enable Go module caching - setup-go needs go.mod/go.sum files to generate cache keys - Update golangci-lint action to v7 and version to v2.6 - Mi... Pull #50 paskal github
95.42
10167092668 master remove unused delete() call, revert LoadingCache.purge changes `purge` call became broken in 41ffddb34, this change reverts it to the old behaviour so that memory won't be freed on its call. It's called relatively frequently and so copying the `d... push umputun github
95.42
10167057871 paskal/fix_expirable_cache remove unused delete() call, revert LoadingCache.purge changes `purge` call became broken in 41ffddb34, this change reverts it to the old behaviour so that memory won't be freed on its call. It's called relatively frequently and so copying the `d... Pull #48 paskal github
95.42
10165675259 master improve v1 expirable cache memory management by recreating map on purge Modified the `Purge` and `purge` methods to recreate the `data` map, allowing the old map to be garbage collected, and added a new test to check for it. push umputun github
95.42
See All Builds (202)