go-pkgz / rest / 32198654843

97%

master: 97%

Build Type

Pull #55

github

Committed by paskal

Commit Message

fix: send the 101 status line before the connection is handed over

WriteHeader only committed when a Content-Type was already set, so the plain
upgrade sequence, 101 with no content type followed by Hijack, recorded the
status and never forwarded it: Hijack set hijacked and close returned at that
guard, leaving the client with the raw protocol bytes and no status line where
net/http would have written one.

101 now commits immediately, which it can do because it carries no body to sniff
and is already excluded from compression. The regression test omits Content-Type
and reads the raw socket, so it fails without the fix.

Reported by umputun on #51.

Pull Request Pull Request #55: Advertise Flusher and Hijacker only when the underlying writer has them

Coverage Stats

17 of 27 new or added lines in 1 file covered. (62.96%)

2 existing lines in 1 file now uncovered.

1645 of 1697 relevant lines covered (96.94%)

47.37 hits per line