go-pkgz / rest / 32198203704

97%

push

github

fix: measure request duration on the injectable clock

Handler took its start time from nowFn but closed the measurement with
time.Since, so the duration always came from the wall clock and no test could
control it. TestBenchmarks_Handler therefore slept 50ms per request and asserted
the result within a 10ms band, which failed roughly one run in ten on a loaded
machine.

Both ends read nowFn now, which is time.Now in production and carries the same
monotonic reading time.Since uses, so the measurement is unchanged there. The
test drives a fake clock instead of sleeping: the numbers are exact rather than
banded, and the package tests run about five seconds faster.

3 of 3 new or added lines in 1 file covered. (100.0%)

1637 of 1677 relevant lines covered (97.61%)

47.69 hits per line