go-pkgz / rest / 32198263088

97%

master: 97%

Build Type

Pull #55

github

Committed by paskal

Commit Message

fix: advertise Flusher and Hijacker only when the writer beneath does

The wrapper implemented both unconditionally, so a handler's type assertion
succeeded even when the writer underneath supported neither, and the Flush that
followed silently did nothing. Timeout is exactly such a writer, so composing it
with Gzip reproduced it. The returned writer is now picked from the capabilities
of the one it wraps.

Hijack also finishes the gzip stream before handing the connection over, so
anything already written reaches the wire, and the deferred-commit deviation
from net/http header semantics is documented rather than papered over.

Pull Request Pull Request #55: Advertise Flusher and Hijacker only when the underlying writer has them

Coverage Stats

14 of 24 new or added lines in 1 file covered. (58.33%)

2 existing lines in 1 file now uncovered.

1644 of 1696 relevant lines covered (96.93%)

47.32 hits per line