umputun / rlb-stats / 32196792923

88%

push

github

fix: merge same-minute candles on save instead of overwriting (#59)

* fix: merge same-minute candles on save instead of overwriting

Bolt.Save keyed candles by StartMinute.Unix() and did a plain Put, so a second
candle for the same minute overwrote the first. This happens when the aggregator
flushes a partial minute on shutdown and the process restarts within that same
minute: the restart's candle replaced the flushed one and its stats were lost.

Merge the incoming candle with any candle already stored for the same key. Normal
operation saves each minute once and never merges; the merge only runs on this
abnormal duplicate-key path. Counts are summed, so an ip+file pair spanning two
fragments can be over-counted - accepted as best-effort recovery versus the
previous behaviour of dropping the earlier fragment entirely.

* fix: overwrite unreadable candle on save instead of failing

per review: if the existing entry for a key can't be unmarshalled, log a
warning and overwrite it rather than returning the error, which would also
drop the new candle and prevent recovery from a single corrupt entry. add a
test planting a corrupt value, and close the temp file handle before Bolt
opens it in the merge test.

29 of 29 new or added lines in 2 files covered. (100.0%)

350 of 412 relevant lines covered (84.95%)

145.92 hits per line