umputun / rlb-stats / 32196765414

88%

push

github

fix: make Aggregator concurrency-safe and fix dedup key collision (#57)

* fix: make Aggregator concurrency-safe and fix dedup key collision

POST /api/insert runs under Throttle(100), so concurrent handlers shared the
Aggregator's entries slice with no synchronisation - a data race that could
drop records or panic. Guard Store and Flush with a mutex and extract the
shared buildCandle helper (removing the duplicated dedupe loop).

Replace the concatenated string dedupe key ("file-ip") with a struct key,
which could otherwise collapse distinct pairs like ("a-b","c") and
("a","b-c") into a single count.

Fully-correct aggregation under out-of-order concurrent inserts also depends
on merging same-minute candles on save (companion PR), since a minute split
across partial candles would otherwise be overwritten by StartMinute key.

* test: tighten concurrent aggregator test per review

correct the comment to say only Store is concurrent (Flush runs after the
wait), and assert Flush actually emits a non-empty candle instead of
discarding its return.

* test: add dedupe-key collision regression test

per review: guards the struct dedup key against a regression to a naive
concatenated string key, which would collapse (file=a-b,ip=c) and
(file=a,ip=b-c) into one count.

18 of 18 new or added lines in 1 file covered. (100.0%)

323 of 385 relevant lines covered (83.9%)

155.92 hits per line