go-pkgz / auth / 32194917390

86%

push

github

fix: keep a single GridFS revision per avatar (#308)

* Keep one gridfs revision per avatar and remove all of them

GridFS appends a new revision on every upload with the same filename, so each
authentication left another copy of the avatar behind, growing files and chunks
without bound. Put now drops the older revisions after a successful upload.

ID and Remove picked an arbitrary revision from an unsorted lookup: ID could
return the hash of an older copy, producing a stale ETag, and Remove could
report success while an older revision stayed readable. ID now reads the newest
revision and Remove deletes every one of them.

* Add coverage for gridfs failure paths

37 of 40 new or added lines in 1 file covered. (92.5%)

3109 of 3627 relevant lines covered (85.72%)

8.65 hits per line