decentraland / asset-bundle-registry / 32186709651

73%

main: 73%

Pull #132

github

refactor(auth): use rejectIfSigner from crypto-middleware 6.1

Replaces the hand-rolled scene gate. The exact comparison let a signer
that was not already canonical through: a padded or re-cased value failed
`!== 'decentraland-kernel-scene'` and the request was served as a directly
user-signed one. rejectIfSigner refuses such a value instead of comparing
it, and refuses a non-string one too. Nothing is folded — the value is
rejected, not rewritten.

The canonical-signer spec now expects the 400 the gate produces rather
than the 401 from signature verification. metadataValidator runs first, so
a re-cased delivery is refused before any crypto rather than after; the
signature would have refused it either way.

666 of 953 branches covered (69.88%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1749 of 2347 relevant lines covered (74.52%)

41.19 hits per line