decentraland / comms-gatekeeper / 32186114728

86%

main: 86%

Build Type

Pull #289

github

Committed by LautaroPetaccio

Commit Message

refactor(auth): use the shared signer predicates from crypto-middleware 6.1

The five hand-rolled metadataValidator closures are replaced by
requireSigner and rejectIfSigner. Same gates, expressed once in the
library rather than repeated per route.

This tightens two of them. The exact comparisons let a signer that was not
already canonical through: `Signer: "Decentraland-Kernel-Scene"` failed
`!== 'decentraland-kernel-scene'` and was served as a viewer request. The
predicates refuse a non-canonical signer instead of comparing it, and
refuse a non-string one too. Nothing is folded — a value is rejected, not
rewritten.

The watcher-token spec covering a re-cased signer now expects the 400 the
gate produces rather than the 401 from signature verification. Both refuse
the request; metadataValidator runs first, so it is now caught before any
crypto rather than after.

Pull Request Pull Request #289: fix(auth): upgrade @dcl/crypto-middleware to 6

Coverage Stats

1142 of 1456 branches covered (78.43%)

Branch coverage included in aggregate %.

14 of 16 new or added lines in 2 files covered. (87.5%)

19 existing lines in 1 file now uncovered.

3123 of 3523 relevant lines covered (88.65%)

77.64 hits per line