temporalio / sdk-java / #359

68%

master: 75%

Build Type

push

github

Committed by web-flow

Commit Message

Report non-retryable PayloadValidationError as BAD_REQUEST (#3009)

## What changed

A data converter can now signal that a Nexus operation's input is invalid by throwing a non-retryable `ApplicationFailure` of type `PayloadValidationError` while deserializing the input. `PayloadSerializer` translates such a failure into a `BAD_REQUEST` `HandlerException` with the message `invalid operation input`, retaining the original failure as its cause.

Previously any `ApplicationFailure` from the data converter propagated and was turned into an `INTERNAL` handler error by `NexusTaskHandlerImpl`, which callers retry — so a caller sending invalid input was retried until timeout instead of failing fast.

## Unchanged

- `ApplicationFailure` of any other type → propagated as before (`INTERNAL`)
- A **retryable** `PayloadValidationError` → propagated as before (`INTERNAL`); non-retryable is required
- `HandlerException` from the converter → passed through untouched
- `InvalidProtocolBufferException` / `DataConverterException` → `BAD_REQUEST` as before
- `serialize()` is untouched — `BAD_REQUEST` would be wrong for a result-encoding failure

## Tests

- `PayloadSerializerTest`: positive case asserting `BAD_REQUEST`, non-retryable, the wrapper message and the preserved cause; negative cases for a different error type and for a retryable `PayloadValidationError`.
- `OperationInputDeserializationErrorPropagationTest`: end-to-end through the test server, including a retryable case that proves the non-retryable guard by being retried.

## Cross-SDK

Part of a coordinated change; equivalent PRs exist for Go, TypeScript, Python and .NET. The wrapper message wording is aligned across SDKs, adapted to each SDK's message style.

Coverage Stats

7405 of 12974 branches covered (57.08%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

17 existing lines in 6 files now uncovered.

30510 of 42764 relevant lines covered (71.35%)

0.71 hits per line