temporalio / sdk-java / #358

68%

master: 75%

Build Type

push

github

Committed by web-flow

Commit Message

💥 Report Nexus input deserialization failures as non-retryable BAD_REQUEST (#3002)

io.nexusrpc:nexus-sdk 0.6.0-alpha no longer wraps serializer errors in a
generic RuntimeException (nexus-rpc/sdk-java#47), so PayloadSerializer is
now the place that decides the error type and retry behavior for them.

Input that will never decode into the expected type, an unparsable Payload
or a DataConverterException, is reported as a non-retryable
HandlerException with error type BAD_REQUEST. Any other failure on the way
to the value propagates untouched so it keeps the handling a failure from
an operation handler would get; in particular a PayloadCodec outage stays
retryable rather than permanently failing an operation over a momentary
blip. A HandlerException or ApplicationFailure raised by the data
converter is also propagated as-is so the converter's own error type and
retry behavior survive.

An operation input type that is neither a Class nor a ParameterizedType is
a handler definition problem rather than a bad request, so it is reported
as a non-retryable INTERNAL.

Result serialization is not translated. Note that as of the Nexus change
above this is no longer the same as being unchanged: a non-retryable
ApplicationFailure raised while serializing a result now reaches
convertKnownFailures and becomes a non-retryable INTERNAL, where it used
to be flattened to a retryable INTERNAL.

BREAKING CHANGE: input a handler cannot deserialize previously failed with
a retryable INTERNAL handler error and was retried until the operation's
schedule-to-close timeout. It now fails immediately with a non-retryable
BAD_REQUEST.

Coverage Stats

7402 of 12970 branches covered (57.07%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

7 existing lines in 3 files now uncovered.

30518 of 42760 relevant lines covered (71.37%)

0.71 hits per line