mozilla / relman-auto-nag / #6005

24%

master: 26%

push

coveralls-python

Format version numbers through get_flag instead of concatenating them

The versions returned by get_checked_versions() are ints, so the rules
that built Bugzilla flag names and values by concatenating them raised
TypeError. missed_uplifts crashed while rendering its email, and tracking
and unlanded had the same latent bug on the esr channel.

get_report_bugs() now takes the channel and the version and derives the
approval flag through get_flag(), which is the single place where a
version gets formatted into a flag name, so callers no longer stringify
or concatenate one. The missed_uplifts template uses Jinja's join filter,
which coerces its items, instead of Python's str.join.

Also drop the int() casts and the type: ignore comment that are no longer
needed now that the versions are ints.

553 of 3200 branches covered (17.28%)

9 of 16 new or added lines in 5 files covered. (56.25%)

2370 of 9805 relevant lines covered (24.17%)

0.24 hits per line