umputun / agterm / 32044160352

93%

push

github

fix: read the quit reason with kAEQuitReason, not a keyword built from a string

The system-quit check never fired. AEKeyword is FourCharCode, which is UInt32, so
AEKeyword("why?") resolves to UInt32.init?(String), the decimal parser, and is always
nil: the if-let chain stopped on its second condition, the alert was still built, and
an unattended restart kept losing every captured command.

The read moves into agtermCore as QuitReason.isSystemQuit, which is what makes it
testable. An inline read in the app target is out of reach for the host-free suite,
and the hosted suite returns .terminateNow under XCUITest before ever reaching it, so
nothing could have caught this. The app target keeps one line.

The tests build the quit event AppKit delivers: shut, rest and rlgo skip the prompt, a
scripted quia keeps it, and an event with no reason attribute or no event at all keeps
it too. Any keyword that fails to resolve now fails these.

4 of 4 new or added lines in 1 file covered. (100.0%)

8016 of 8182 relevant lines covered (97.97%)

4987178.06 hits per line