mxschmitt / playwright-go / 31999171077

78%

push

github

fix: report invalid GetBy*/HasText argument types instead of panicking (#637)

The GetBy* text parameters are `any` because Go has no string|RegExp union, but
the selector helpers assumed anything that was not a regexp was a string:

    func escapeForTextSelector(text any, exact bool) string {
        switch text := text.(type) {
        case *regexp.Regexp:
            return escapeRegexForSelector(text)
        default:
            ...escapeText(text.(string))   // unchecked

so page.GetByText(42) crashed with

    panic: interface conversion: interface {} is int, not string

This affects GetByText, GetByLabel, GetByPlaceholder, GetByAltText, GetByTitle
and GetByTestId on Page, Frame, Locator and FrameLocator, plus GetByRole's
Name/Description options and the HasText/HasNotText locator options, which run
through the same two helpers.

Upstream types these parameters `string | RegExp` and lets the compiler reject
anything else — escapeForTextSelector there is simply
`if (typeof text !== 'string') return escapeRegexForSelector(text)`
(packages/isomorphic/stringUtils.ts). Go gets no such guarantee at the call
site, so the check has to happen at runtime.

Make both escape helpers (and the getBy*Selector helpers above them) return an
error, and have each GetBy* return a Locator carrying it. That matches how the
package already reports a bad Locator() parameter — via Locator.Err() and from
every action on the locator — and how Fetch, NewCDPSession, Clock and
convertInputFiles already report unsupported argument types, naming the type
they got.

newLocator folds HasText/HasNotText failures into the locator's existing err,
alongside the ErrLocatorNotSameFrame handling that was already there.


Claude-Session: https://claude.ai/code/session_01Hr35MBUfsUG9DnxhBgBcZW

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

165 of 225 new or added lines in 5 files covered. (73.33%)

9249 of 11624 relevant lines covered (79.57%)

13864.75 hits per line