ruby-grape / grape / 31996848490

97%

push

github

Deprecate the positional options Hash in requires, optional and use (#2853)

#2618 replaced `attrs.extract_options!` with an explicit `**opts`
parameter. The two are not equivalent: Ruby only converts a trailing
Hash into keyword arguments when it is written without braces, so a
braced Hash now stays in the splat and is taken for a parameter name.

`optional :id, { type: Integer }` silently lost its coercion,
`requires :id, { type: Integer }` made every request fail with
`{type: Integer} is missing`, and `use :pg, { foo: 1 }` raised
`Params :{foo: 1} not found!`.

Restore the old behaviour behind a deprecation warning, following
`merge_legacy_auth_options`. The trailing Hash is splatted back as
keyword arguments and the method re-invoked, so Ruby redoes the
keyword routing: merging into `**opts` in place would strand `:using`
and `:except` there while their explicit keyword parameters stayed nil.

Fixes #2851

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

1210 of 1299 branches covered (93.15%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

3829 of 3896 relevant lines covered (98.28%)

26688.12 hits per line