mxschmitt / playwright-go / 31992246112

78%

Build Type

push

github

Committed by web-flow

Commit Message

fix: accept mixed string/regexp lists in ToHaveText, ToContainText, ToHaveClass (#634)

These three assertions document `expected` as "string or RegExp or a list of
those" (upstream `Array<string|RegExp>`), but dispatched on the concrete slice
type:

    switch expected.(type) {
    case []string, []*regexp.Regexp:

so only homogeneous lists took the array path. A mixed list such as
`[]any{"foo", regexp.MustCompile("bar")}` fell through to the scalar branch and
failed with "value must be a string or regexp".

Upstream branches on `Array.isArray(expected)` and lets
`serializeExpectedTextValues` validate each element, so element types never
select the branch. Mirror that: dispatch on whether `expected` is a slice, and
leave per-item validation to toExpectedTextValues, which already rejects
anything that is not a string or regexp.

Homogeneous `[]string` and `[]*regexp.Regexp` are unaffected. `ToContainClass`
is deliberately untouched: upstream types it `string|string[]` and explicitly
rejects RegExp, which the existing `[]string`/`string` switch with its `%T`
default already enforces.


Claude-Session: https://claude.ai/code/session_01Hr35MBUfsUG9DnxhBgBcZW

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

9 of 11 new or added lines in 2 files covered. (81.82%)

147 existing lines in 1 file now uncovered.

9140 of 11472 relevant lines covered (79.67%)

14765.63 hits per line