mxschmitt / playwright-go / 31989952511
80%
main: 78%

LAST BUILD BRANCH: cursor/cdp-download-guid-test-8e4e
DEFAULT BRANCH: main
Ran
Jobs 9
Files 62
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.639%. Remained the same
31989952511

Pull #632

github

mxschmitt 
test: stop TestShouldUploadAFolderRemote from eating the package timeout

The WebKit-on-macOS folder-upload flake was mitigated in #616 with an
in-test retry loop (3 attempts) plus a 180s action timeout. Since #621
CI also re-runs failed tests via gotestsum --rerun-fails=2, so the flake
now had two retry layers -- and the in-test one is the expensive one: a
wedged attempt burns its full 180s inside the same `go test -timeout=15m`
budget as the other 723 tests.

On run 31647267347 two attempts wedged and the third passed, so the test
reported PASS after 366.99s (baseline: 1.37s). That pushed the ~490s
suite past 900s, and the resulting timeout panic made gotestsum bail out
with "rerun aborted because previous run had a suspected panic" --
disabling the retry safety net for the whole job.

Drop the in-test retry and the inflated timeout, and let gotestsum supply
the retries instead: it re-runs in a fresh process with its own -timeout
budget, and records the failed attempt so the flake stays visible on
flakiness.io rather than being swallowed by a silent in-test retry.

Observed durations are bimodal -- ~1s when it works, "never" when it
wedges -- so the shorter timeout does not reduce the odds of passing, it
only bounds what a wedge costs. Verified locally on macOS/arm64: 22 runs
under WebKit (incl. --race and heavy CPU contention) plus chromium and
firefox all complete in <=1.5s.

withRetry/attemptT had no other callers and are removed with it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RbHRZ366YgsmofGFq21Kxy
Pull Request #632: test: stop TestShouldUploadAFolderRemote from eating the package timeout

9121 of 11453 relevant lines covered (79.64%)

15158.72 hits per line

Jobs
ID Job ID Ran Files Coverage
1 windows-latest-chromium - 31989952511.1 62
79.34
 GitHub Action Run
2 macos-latest-chromium - 31989952511.2 62
79.36
 GitHub Action Run
3 windows-latest-firefox - 31989952511.3 62
78.01
 GitHub Action Run
4 ubuntu-latest-webkit - 31989952511.4 62
77.89
 GitHub Action Run
5 ubuntu-latest-firefox - 31989952511.5 62
78.03
 GitHub Action Run
6 windows-latest-webkit - 31989952511.6 62
77.94
 GitHub Action Run
7 ubuntu-latest-chromium - 31989952511.7 62
79.36
 GitHub Action Run
8 macos-latest-webkit - 31989952511.8 62
77.43
 GitHub Action Run
9 macos-latest-firefox - 31989952511.9 62
78.03
 GitHub Action Run
Source Files on build 31989952511