wol-soft / php-json-schema-model-generator / 31972611204

99%

master: 99%

Pull #157

github

Close remaining Phase 3 coverage gaps for accessor mutation paths

Cross-referenced a fresh --coverage-clover run against the original
gap analysis (57 uncovered lines) rather than trusting behavioral
verification alone. Closes two of the four remaining lines:

- UnevaluatedItemsValidatorFactory's dead-code classifier falls
  through to "not dead code" for items: null (not a valid items
  value) rather than misclassifying it as one of the three recognised
  dead-code shapes.

Also documents a genuine, previously-undiscovered bug found while
tracing the other two lines: a composition branch's own
unevaluatedProperties never sees properties the enclosing schema (or
a sibling branch) declares -- only the reverse direction (branch
claims propagating up to an outer unevaluatedProperties) was ever
built. `{properties: {name}, allOf: [{unevaluatedProperties: false}]}`
wrongly rejects {name: "Alice"} even though name is declared and
validated by the enclosing schema. Root cause and revisit trigger are
in implementation-plan.md item 20; surfaced here via markTestIncomplete
since the fix touches how a branch's nested class computes its
evaluated set, not a single call site.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

1087 of 1097 new or added lines in 43 files covered. (99.09%)

8952 of 9051 relevant lines covered (98.91%)

575.6 hits per line