bleedingdeacons / trusted / 31936656233
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 27
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 93.551%. Remained the same
31936656233

push

github

web-flow 
feat(testing): ship the rota doubles from src so consumers can use them (#53)

InMemoryRotaRepository and InMemoryAssignmentRepository already existed
under tests/Fixtures, which put them out of reach of every other plugin:
tests/ is mapped by autoload-dev only, so a consumer that needs a rota
repository has to write its own. Promises was about to.

Moves both to src/Testing/Doubles under Trusted\Testing\Doubles, matching
Unity\Testing\Doubles, and adds the ABSPATH guard shipped files carry.
ResponderStub stays in tests/Fixtures — it is a Unity MemberStub subclass
for this suite's convenience, not a double for a Trusted contract.

Two correctness fixes the move forced, both cases of a shape that was
adequate as a private fixture and wrong as something others build on:

- findForWeek() ignored the week and returned every slot. The only
  caller in this suite never asks for a week, so nothing noticed; a
  consumer asserting "this week holds two shifts" would have passed
  against a repository that simply handed back everything, then failed
  against the real one. It now filters the 7-day window the interface
  specifies.
- findByRotaIds() returned a flat list where the contract is keyed by
  rota_id. PHPStan found this the moment the file entered src/ (paths is
  src only, so tests/ was never analysed). A consumer eager-loading a
  week's assignments would have got a 0..n list and found nothing under
  any rota id.

phpunit.xml.dist excludes src/Testing from the coverage denominator, as
Unity does and for the same reason.

Gates: PHPUnit 250 tests, PHPStan level 8, PHPCS all green.

1378 of 1473 relevant lines covered (93.55%)

3.99 hits per line

Jobs
ID Job ID Ran Files Coverage
1 31936656233.1 27
93.55
GitHub Action Run
Source Files on build 31936656233