sgobotta / live_dj / 86904c01c9fe718e3cef524295bac697f482942b
68%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 82
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.63% (-0.03%) from 67.663%
86904c01c9fe718e3cef524295bac697f482942b

push

github

web-flow 
Add arrow-key navigation across the playlist (#141)

* Add arrow-key navigation across the playlist

Focusing #lists (the room's playlist panel) used to mean tabbing
through every track link one at a time. Make the list itself a single
Tab stop instead: every track link now sits at tabindex="-1", and a
new PlaylistKeyboardNav hook moves real DOM focus between them on
ArrowDown/ArrowUp (clamped at the ends, no wraparound), scrolling the
target into view. Enter still plays the focused track for free, since
that's native <a> activation behavior independent of tabindex.

Also gives #lists an explicit tabindex="0" (rather than relying on
Chromium's implicit scroll-container focusability, which Firefox/
Safari don't share) plus role="listbox" / role="option" /
aria-selected, matching the existing command-palette convention in
this codebase, and a visible focus-visible ring so the container
itself isn't silently focusable-but-invisible.

* Make the playlist container's focus indicator dotted, not a solid ring

outline supports dash styles directly (box-shadow-based rings don't),
so swap ring-2/ring-offset for outline-2 outline-dotted with the same
offset — a lighter-weight cue for what's otherwise a brief, transient
state (focus usually moves onto a track immediately via arrow keys).

* Reduce the playlist container's outline opacity

outline-brand/50 instead of the full-strength color, so the dotted
line reads even quieter.

1381 of 2042 relevant lines covered (67.63%)

29.64 hits per line

Coverage Regressions

Lines Coverage ∆ File
19
21.88
 -0.71% //lib/livedj_web/components/list_component.ex
1
41.99
 0.0% //lib/livedj/sessions.ex
Jobs
ID Job ID Ran Files Coverage
1 86904c01c9fe718e3cef524295bac697f482942b.1 82
67.63
 GitHub Action Run
Source Files on build 86904c01c9fe718e3cef524295bac697f482942b