archetech / archon / 31911220267

87%

push

github

feat: Serve the node's own explorer publicly at /explorer (#895)

* feat: Serve the node's own explorer publicly at /explorer

A node could not link to its own explorer, so Herald had to advertise
explorer.archon.technology. The obvious "same node" default of
localhost:4000 resolves to the *visitor's* machine, since the link is
followed by their browser.

Three things had to change together; a Drawbridge route alone would have
served a broken app.

Prefix. The bundle was built with base '/', so serving it under /explorer
would have left every asset URL pointing at the host root. base is now
VITE_EXPLORER_BASE (default /explorer/), the router takes its basename
from the same value so deep links resolve, and server.js mounts the app at
the same prefix. That keeps direct access on :4000 and proxied access
byte-identical rather than having two behaviours to reason about. The
image is prefix-specific as a result, which the issue anticipated.

Backend URLs. VITE_GATEKEEPER_URL and VITE_SEARCH_SERVER were baked into
the bundle and defaulted to loopback. These are browser-side fetches, so a
publicly served explorer would have sent every visitor to their own
machine -- the same defect as the Herald link, one layer down. They are
served at runtime from /explorer/config.json and fetched before first
paint, with the build-time values kept as the fallback so existing local
setups are unchanged.

Drawbridge route. /explorer proxies to the explorer, or answers 501 when
the profile is not enabled, matching /names and /didcomm. It passes an
empty prefixToStrip: unlike those two, the prefix has to survive the hop,
because the app is mounted at it.

Herald default. ARCHON_HERALD_EXPLORER_URL now defaults to
${DRAWBRIDGE_PUBLIC_HOST}/explorer instead of the public instance, derived
the same way PUBLIC_URL already is for /names. Still overridable, and
still hideable by setting it empty.

Verified against a running server: assets resolve under the prefix and
404 without it... (continued)

3746 of 4214 branches covered (88.89%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

8391 of 8680 relevant lines covered (96.67%)

680.26 hits per line