Tatsh / destin / 31904042002

100%

push

github

misc.sc_info: read every record in an SC_Info

A directory holds one set of protection files per executable, not one
set outright, and 62 of the 3401 bundles measured hold two. One shape is
architecture-specific, BofA_armv7.sinf and BofA_armv7.supp beside
BofA.sinf; the other is left behind by a renamed executable, Chase.sinf
beside Chase iPad.sinf. Only one was read and the rest were dropped.

Group the files by the stem they share and read every set, the way every
bundle of a download is read. A set need not be complete: of the sets in
those directories 38 carry a .supf and a .supp, 33 only a .supp, and 53
neither, and 16 directories carry supplements with no .sinf at all, so a
stem seen on any of the four suffixes makes a set.

The manifest picks the main one, since SinfPaths names that record and no
other; failing that the set named after the bundle wins, then the first
in name order. Verified against all 62: the main record's name matches
the bundle's own in every one. The stale set matches the previous build,
BofA 6.2.8's BofA_armv7.supp holding exactly the page count of BofA
6.2.0's binary.

SCInfo keeps sinf, supf, supp, and supx as properties onto the main
record, so reading one stays a one-liner. The JSON grows a records array
in their place, each entry naming its set and carrying its own checks,
mirroring the one-entry-per-bundle list above it. The report heads each
set with the executable it protects.

Rename ScInfo to SCInfo and the new type to SCRecord, keeping the
acronym's casing.

Also tighten two docstrings against evidence. The supp record rule has no
exceptions once every Mach-O is found by scanning page boundaries rather
than trusting the fat header: the 117 executables that appeared to break
it carry an appended slice their header does not declare, and all 163
re-tested bundles then satisfy it exactly. And record that these
certificates are meant to be expired: all 5962 carry the same 2008 to
2013 window from a pool of twelve ser... (continued)

1777 of 1791 branches covered (99.22%)

Branch coverage included in aggregate %.

110 of 111 new or added lines in 2 files covered. (99.1%)

13795 of 13918 relevant lines covered (99.12%)

4.96 hits per line