decentraland / deployments-to-sqs / 31901628182

91%

push

github

refactor: migrate from @well-known-components to @dcl core-components (#534)

* refactor: migrate from @well-known-components to @dcl core-components

Replaces every `@well-known-components` package that has a core-components
equivalent, and bumps `@dcl/snapshots-fetcher` 9.1.0 -> 11 with the
`@dcl/catalyst-storage` 4 -> 5 bump it requires.

The snapshots-fetcher bump is what drives the rest: v9.x/v10 shipped
unimportable (an undeclared `fp-future` meant a production install threw
MODULE_NOT_FOUND from `dist/index.js`), and v11 takes its fetcher as the
native `IFetchComponent` from `@dcl/core-commons` — so the node-fetch
adapter, the HTTP server and the metrics component all had to move
together. v11 also brings SSRF/DNS-rebinding guards on redirects, a
pagination bound, gzip-bomb and transfer-rate caps, a /pointer-changes
timeout, and fixes for shutdown hangs.

## Swaps

- http-server -> `@dcl/http-server`, metrics -> `@dcl/metrics`,
  test-helpers -> `@dcl/test-helpers`
- `src/adapters/fetch` (node-fetch) -> `@dcl/fetch-component`
- `IFetchComponent`/`IHttpServerComponent` now come from `@dcl/core-commons`
- deep imports into `snapshots-fetcher/dist/*` and
  `catalyst-storage/dist/*` replaced with root imports; the latter is a
  hard requirement, since catalyst-storage v5 blocks them via `exports`
- `logger`, `env-config-provider` and `interfaces` stay on WKC (no core
  equivalent); interfaces bumped to ^1.5.2

`@dcl/core-commons` is pinned exactly, matching the exact pin http-server,
fetch-component and test-helpers all declare, so only one copy resolves.

## Fixes surfaced by the bumps

- `createResilientContentStorage` swallowed the storage lifecycle. v4 had
  none; v5 adds `start`/`stop` (the folder backend replays its
  crash-recovery journal in `start`). The wrapper returned a literal of
  data methods only, and since every `IBaseComponent` member is optional
  this compiled clean. It now forwards them, and the new `range` argument
  to `retri... (continued)

47 of 62 branches covered (75.81%)

Branch coverage included in aggregate %.

27 of 28 new or added lines in 6 files covered. (96.43%)

248 of 266 relevant lines covered (93.23%)

3.78 hits per line