sgerrand / git_hoox / 31874847453

98%

push

github

fix(runner): keep output from hooks cancelled by fail_fast (#25)

In parallel mode a fail_fast halt tears down the async_stream, which
terminates the hooks still in flight. Each task owned its own StringIO
capture device and flushed it on the way out, so a cancelled hook lost
both: the device died with the task, and the task-side flush never ran
because the tasks do not trap exits. A hook could run for seconds,
print diagnostics the whole time, and leave nothing on screen — the
worst case being the run that just failed and most needs explaining.

Open the devices in run_parallel/4 and lend them to the tasks. The
runner flushes each buffer as its outcome arrives, and an `after`
block drains and closes whatever is left, in configuration order, once
the stream is done or halted. Buffers now outlive their tasks, so a
cancelled hook still prints what it wrote before it was killed.
StringIO.flush/1 empties as it reads, so devices already drained by
the outcome path flush to "" rather than printing twice.

Cancellation itself is unchanged: fail_fast still stops the stage
promptly rather than waiting for in-flight hooks, and a cancelled
hook's outcome is still discarded. Only the output is recovered.

14 of 14 new or added lines in 1 file covered. (100.0%)

634 of 646 relevant lines covered (98.14%)

28.84 hits per line