sgerrand / git_hoox / 31589465432

98%

push

github

refactor: simplify hooks, config, installer and doctor (#23)

* refactor(hooks): centralise command execution in Helpers

Every built-in hook hand-threaded `env: Helpers.env_opt(opts)` into
Cmd.run/3, and Test.exec/2 and Mix.exec/2 were byte-identical private
functions. Add Helpers.cmd/3 and Helpers.mix/2 so `:env` has a single
enforcement point, matching its three global siblings (`:files`,
`:timeout`, `:stage_fixed`), which the runner already enforces
centrally.

The `:args` NimbleOptions entry was copy-pasted into five hook
schemas with only the doc string differing; it now comes from
Helpers.args_schema/1.

Also drops two single-use resolver wrappers in Shell in favour of
direct captures, and swaps Test's two prefix/suffix regexes for
String.replace_prefix/3 and String.replace_suffix/3.

* perf(format): skip the worktree diff on check_only runs

`mix format --check-formatted` never writes, so the follow-up
`git diff --name-only` looking for files to re-stage could not find
anything the hook had modified. Return a bare `:ok` in that case and
save one git subprocess per commit.

This also stops a check_only run from re-staging unrelated unstaged
edits, which the previous `{:ok, changed}` return did whenever the
default `stage_fixed: true` was left in place.

While here, adopt Helpers.cmd/3 and Helpers.args_schema/1, and build
the argument list from a flag list instead of branching over the
whole list. Argument order is unchanged.

* refactor(installer): derive hook filenames from the stage list

The eight git stages were written out twice — as snake_case atoms in
Config.Schema and again as kebab-case strings in Installer — and the
atom-to-filename transform a third time, inline in the run task's
error message. Forgetting the Installer list meant no shim was
written, with nothing to catch it.

Add Schema.hook_filename/1 and Schema.hook_filenames/0 beside
parse_stage/1, and build Installer's list and the run task's message
from them. Schema.valid_stag... (continued)

74 of 75 new or added lines in 14 files covered. (98.67%)

630 of 642 relevant lines covered (98.13%)

28.7 hits per line