sgobotta / live_dj / 1c957c23f65e508dc5c08fde72585e1024ea4ada
68%

DEFAULT BRANCH: dev
Ran
Jobs 1
Files 82
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 67.476% (+0.5%) from 67.016%
1c957c23f65e508dc5c08fde72585e1024ea4ada

push

github

web-flow 
Show a browser notification whenever the playing track changes (#136)

* Show a browser notification whenever the playing track changes

Every track change (selected from the playlist, skipped forward/back,
or auto-advanced) already converges on the same :player_load_media
broadcast handled by PlayerControlsLive, so that's the single place to
push the new track's title/channel/thumbnail to a client-side hook.
The hook requests Notification permission lazily, on the first track
change rather than page load, since browsers discourage prompting
before any user interaction.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XUHGwYQNDnjt6kfvBSr1NB

* Add an on/off toggle for track-change notifications

Notifications were previously gated only by the browser's own
permission prompt, with no way to opt out short of revoking that
permission. Adds an app-level preference in the settings modal's
General tab, off by default and persisted in localStorage — the
TrackNotifications hook now checks it before ever requesting
permission or showing anything.

Kept entirely client-side: the toggle has no server-side effect to
synchronize (unlike volume mute, which reaches into the YouTube
player), so a push_event/connect_param round-trip through RoomLive.Show
would add complexity for no benefit. The two hooks coordinate purely
through localStorage.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XUHGwYQNDnjt6kfvBSr1NB

* Give the settings modal a consistent height across tabs

General's content now runs taller than Security's, so switching tabs
visibly shrank/grew the modal (measured 356px vs 224px). Raises both
tabs' shared min-height to fit the taller one, so the modal stays the
same size regardless of which tab is active.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XUHGwYQNDnjt6kfvBSr1NB

-------... (continued)

1361 of 2017 relevant lines covered (67.48%)

28.31 hits per line

Coverage Regressions

Lines Coverage ∆ File
9
54.46
 1.39% //lib/livedj_web/components/session_modals.ex
2
77.78
 11.11% //lib/livedj_web/live/player_controls_live.ex
1
41.24
 0.0% //lib/livedj/sessions.ex
1
86.67
 1.76% //lib/livedj_web/components/custom_components.ex
Jobs
ID Job ID Ran Files Coverage
1 1c957c23f65e508dc5c08fde72585e1024ea4ada.1 82
67.48
 GitHub Action Run
Source Files on build 1c957c23f65e508dc5c08fde72585e1024ea4ada