medplum / medplum / 31847754187

92%

main: 92%

push

github

perf(subscriptions): drop redundant deepClone in the subscription worker (#10213)

readVersion builds its result from parseHistoryContent, which is a JSON.parse of
the history row, and removeHiddenFields then mutates and returns that same
object. The resource is therefore already private to this caller, so cloning it
before rewriteAttachments copied something no one else could observe. Its only
consumers are execBot and sendRestHook, and it is not read afterwards.

The clone was redundant before the attachment-rewrite fast path as well, since
rewriteAttachments rebuilt the whole object graph anyway. It is removed here
rather than in that change because it needs its own verification.

Adds a test pinning the invariant the removal depends on: two readVersion calls
must not share structure. If a future in-process cache makes readVersion hand
out shared objects, that test fails and flags every caller that mutates its
result in place.

Signed-off-by: Derrick Farris <derrick@medplum.com>

24040 of 27218 branches covered (88.32%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

42390 of 44839 relevant lines covered (94.54%)

11751.09 hits per line