medplum / medplum / 31847753089

92%

main: 92%

push

github

perf(fhir): skip attachment rewrite when a resource has no attachments (#10204)

rewriteAttachments runs on every authenticated response and rebuilt the entire
object graph via Object.fromEntries, awaiting once per property, even when the
payload contained no attachments at all. That is the common case.

Check for a binary URL first and hand the input back untouched when there is
nothing to rewrite. For a 1000-resource search Bundle this replaces a ~13ms
rebuild with a ~1ms scan.

The predicate tests for an actual binary via normalizeBinaryUrl rather than for
the presence of a `url` property: every FHIR extension carries a `url`, so a
presence check would fall through to the slow path on most real resources.

Because the result may now be the input itself, callers that mutate it have to
copy first. Only the update path did: replaceConditionalReferences rewrites
nested references in place, and previously relied on the rewrite having already
detached the resource from validatedResource and the cached existing resource.
That copy is now explicit at the call site. Every other caller only serializes
the result, and the subscription worker already deep-cloned its input.

Signed-off-by: Derrick Farris <derrick@medplum.com>

24040 of 27218 branches covered (88.32%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 2 files covered. (100.0%)

42390 of 44839 relevant lines covered (94.54%)

11751.05 hits per line